-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qute support for multi module project #940
Conversation
This PR requires vscode-quarkus redhat-developer/vscode-quarkus#627 PR if you wish to test it in vscode-quarkus |
c5ec2e7
to
67a229b
Compare
To test this PR, open https://github.com/gbourant/multi-module-template-test. The use case is that index.html from project-b include the template root.html from the project-a (where project-b have a dependency to project-a). With this PR:
Here a demo: Here the limitation of the current worl:
@fbricon could we see those limitations in separate PR because it requires to improve the data model change event to be have more information like the new project dependencies, if teh changes comes from a java sources and dependencies, etc |
67a229b
to
2ee9cc2
Compare
I need to clean my code and write tests but @fbricon you can play with the PR (please see the limitations that I have listed) |
qute.ls/com.redhat.qute.ls/src/main/java/com/redhat/qute/ls/api/QuteProjectInfoProvider.java
Show resolved
Hide resolved
seems to work for for includes, but not for user tags. If you create a https://github.com/gbourant/multi-module-template-test/tree/master/project-a/src/main/resources/templates /tags/link.html, then you have no completion, nor navigation for {#link} in https://github.com/gbourant/multi-module-template-test/blob/master/project-b/src/main/resources/templates/index.html |
2ee9cc2
to
5719ac0
Compare
actually if you put any user tags in project a, then all user tags in project b disappear from rendering. @mkouba is that intended? I then don't understand how Renarde works, since it also contributes user tags |
5719ac0
to
c8de48e
Compare
I can confirm that this happened to me too. That's why i moved the tags to project-b when i reported the Properties should be available recursively #939 |
Fixes redhat-developer#930 Signed-off-by: azerr <[email protected]>
c8de48e
to
1ebac0a
Compare
The PR contains now tests and the code should be cleaned, @fbricon please review it. |
thanks @angelozerr |
Qute support for multi module project
Fixes #930